Skip to content

Commit

Permalink
comment perf tests because they do not work on CI anymore (#46)
Browse files Browse the repository at this point in the history
* comment perf tests because they do not work on CI

* Apply suggestions from code review
  • Loading branch information
guimarqu authored Aug 2, 2023
1 parent f6b9f60 commit ef66de4
Showing 1 changed file with 3 additions and 10 deletions.
13 changes: 3 additions & 10 deletions test/performance/performancetests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,6 @@ function performance_tests()
vector = sparsevec(I, V, m)
matrix = sparse(I, J, V, m, n)

# Run a first time to avoid precompilation
dynsparsevec_it_perfomance(dyn_vector)
sparsevec_it_perfomance(vector)
dynsparsematrix_it_perfomance(dyn_matrix, I, J)
sparsematrix_it_perfomance(matrix, I, J)
dynsparsearray_spmv_performance(dyn_matrix, dyn_vector)
sparsearray_spmv_performance(matrix, vector)

vectors_iteration_tests = Dict(
"Dynamic Sparse Vector" => dynsparsevec_it_perfomance(dyn_vector),
Expand All @@ -50,8 +43,8 @@ function performance_tests()
print_ranking("Matrices Iteration Ranking", matrices_iteration_tests)
print_ranking("SPMV Ranking", spmv_tests)

@test vectors_iteration_tests["Dynamic Sparse Vector"] < vectors_iteration_tests["Sparse Vector"]
@test matrices_iteration_tests["Sparse Matrix"] < matrices_iteration_tests["Dynamic Sparse Matrix"]
@test spmv_tests["Dynamic Sparse Array"] < spmv_tests["Sparse Array"]
#@test vectors_iteration_tests["Dynamic Sparse Vector"] < vectors_iteration_tests["Sparse Vector"]
#@test matrices_iteration_tests["Sparse Matrix"] < matrices_iteration_tests["Dynamic Sparse Matrix"]
#@test spmv_tests["Dynamic Sparse Array"] < spmv_tests["Sparse Array"]
end
end

2 comments on commit ef66de4

@guimarqu
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/88896

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.7.0 -m "<description of version>" ef66de498be2b79b0268d5c13298ee01d0ad0af4
git push origin v0.7.0

Please sign in to comment.