Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatRoom and Append rights #381

Merged
merged 29 commits into from
May 22, 2022
Merged

ChatRoom and Append rights #381

merged 29 commits into from
May 22, 2022

Conversation

joepio
Copy link
Member

@joepio joepio commented Apr 12, 2022

TODO:

  • It's working!
  • Fix sorting
  • Push method for Commits (closes Push method for commits #388)
  • Append-only right
  • Update data-browser assets, depends on ChatRoom atomic-data-browser#153
  • Add e2e test for ChatRoom. Invite, open, chat, reply, websockets.
  • Fix home resource. There's a problem when signing authentication for the / resource, where the client appends a slash.

PR Checklist:

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #381 (45c0a59) into master (3e82dbe) will increase coverage by 0.66%.
The diff coverage is 76.70%.

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   64.23%   64.90%   +0.66%     
==========================================
  Files          69       70       +1     
  Lines        6551     6673     +122     
==========================================
+ Hits         4208     4331     +123     
+ Misses       2343     2342       -1     
Impacted Files Coverage Δ
lib/src/lib.rs 100.00% <ø> (ø)
lib/src/plugins/chatroom.rs 0.00% <0.00%> (ø)
lib/src/validate.rs 9.00% <0.00%> (ø)
server/src/commit_monitor.rs 20.54% <0.00%> (ø)
server/src/errors.rs 23.45% <ø> (-0.94%) ⬇️
server/src/handlers/commit.rs 0.00% <ø> (ø)
server/src/handlers/search.rs 30.20% <ø> (+0.20%) ⬆️
server/src/handlers/upload.rs 0.00% <0.00%> (ø)
server/src/handlers/web_sockets.rs 0.00% <0.00%> (ø)
server/src/serve.rs 0.00% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e82dbe...45c0a59. Read the comment docs.

@joepio joepio marked this pull request as ready for review May 22, 2022 19:29
@joepio joepio merged commit 41b9309 into master May 22, 2022
@joepio joepio deleted the #373-chatroom branch May 22, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants