Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of panics in commit_monitor #345

Closed
joepio opened this issue Mar 23, 2022 · 0 comments · Fixed by #376
Closed

Get rid of panics in commit_monitor #345

joepio opened this issue Mar 23, 2022 · 0 comments · Fixed by #376
Milestone
v0.32 self-hosting

Comments

@joepio
Copy link
Member

joepio commented Mar 23, 2022 •
edited
Loading

Handler<CommitMessage> has a bunch of .unwrap()s because the handle function in actix does not return a Result.

I don't want to panic the server when anything here goes wrong (at least not in production). I'd rather log the error, and keep the thing going.

Maybe use catch_unwind? Edit: does not seem to work, I can't move the logic to a closure
@joepio joepio added this to the v0.32 self-hosting milestone Mar 23, 2022
joepio added a commit that referenced this issue Mar 23, 2022
@joepio
#345 fix commit index
1363380
@joepio joepio mentioned this issue Mar 23, 2022
Merged
4 tasks
joepio added a commit that referenced this issue Mar 23, 2022
@joepio
#345 fix commit index (#346)
ba9952f
@joepio joepio reopened this Mar 23, 2022
joepio added a commit that referenced this issue Apr 9, 2022
@joepio
#345 get rid of unwraps in commit monitor
012c4de
joepio added a commit that referenced this issue Apr 9, 2022
@joepio
#345 get rid of unwraps in commit monitor
5a52f9b
@joepio joepio mentioned this issue Apr 9, 2022
Merged
4 tasks
joepio added a commit that referenced this issue Apr 9, 2022
@joepio
#345 get rid of unwraps in commit monitor
ba3ade9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.32 self-hosting
Development

Successfully merging a pull request may close this issue.

#345 get rid of unwraps in commit monitor atomicdata-dev/atomic-server
1 participant
@joepio