Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fix invalid reference to item field and remove unused variables #374

Merged
merged 1 commit into from
Sep 11, 2016
Merged

Fix invalid reference to item field and remove unused variables #374

merged 1 commit into from
Sep 11, 2016

Conversation

Ingramz
Copy link
Contributor

@Ingramz Ingramz commented Sep 10, 2016

No description provided.

@winstliu
Copy link
Contributor

winstliu commented Sep 10, 2016

No description provided.

What does this fix? How does one encounter this? Are there any open issues pertaining to this? etc.

@Ingramz
Copy link
Contributor Author

Ingramz commented Sep 10, 2016

It's a mistake or unintended feature that coffeescript allowed in older versions. Newer versions of coffeescript transpile the item parameter as item1 to avoid naming conflict with the line that was changed. If you use an older version of coffeescript, it fixes nothing, in newer versions the code would fail.

http://coffeescript.org/#1.9.0

Changed strategy for the generation of internal compiler variable names.

@Ingramz Ingramz changed the title Fix invalid reference to item field Fix invalid reference to item field and remove unused variables Sep 11, 2016
@Ingramz
Copy link
Contributor Author

Ingramz commented Sep 11, 2016

Also removed some unused variables that were found with coffeescope. I verified that the "invalid" reference was the only one.

@winstliu
Copy link
Contributor

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants