This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Allow enterprise github usage #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to configuer host and API path prefix to allow usage of Enterprise on premise Github repos.
feugy
commented
Sep 15, 2016
| @@ -29,10 +29,13 @@ | |||
| "dependencies": { | |||
| "bluebird": "^3.0.6", | |||
| "expand-home-dir": "0.0.3", | |||
| "github": "^0.1.16", | |||
| "github": "^3.0.0", | |||
There was a problem hiding this comment.
Required to access Enterprise github.
No need to specify a given version when instantiating the wrapper.
| "yargs": "^3.31.0" | ||
| }, | ||
| "devDependencies": { | ||
| "babel-cli": "^6.14.0", |
There was a problem hiding this comment.
Because some folks doesn't have babel globally installed :)
| timeout: 10000, | ||
| protocol: 'https' | ||
| }); | ||
| function authenticate({host, pathPrefix} = {}) { |
There was a problem hiding this comment.
Rather than using a global unic wrapper, creates during authentication, that allows to configure host
| }; | ||
| if (host) { | ||
| opts.pathPrefix = pathPrefix || '/api/v3'; | ||
| opts.host = host; |
There was a problem hiding this comment.
pathPrefix is required to access Enterprise github, however, it's reasonable to provide a default value.
|
Thanks for the PR, I'll take a look this weekend. |
|
Up 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to configuer host and API path prefix to allow usage of Enterprise
on premise Github repos.
Also update to latest github API wrapper, required to access Enterprise Github.