This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix two issues in utf8 <-> utf16 offset & lengths conversions #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not merge it in yet, I want to investigate why https://github.com/atom/first-mate/blob/master/spec/grammar-spec.coffee#L796 fails with this change |
|
Sounds good. I'll mark it as |
…g to the code point start
alexdima
changed the title
|
The second problem was a wrong assumption (again 😊) on my side that code points requiring 3 or 4 bytes in utf8 must necessarily require 4 bytes in utf16. The second commit fixes this assumption by actually recording where a code point starts in the utf16 string. @lee-dohm Thank you, it is now ready for review 👍 |
|
👍 |
zcbenz
added a commit
that referenced
this pull request
Jan 29, 2016
Fix two issues in utf8 <-> utf16 offset & lengths conversions
|
Thank you very much! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zcbenz
I am sorry my previous pull request #46 introduced a regression around utf8 <-> utf16 conversion, specifically I misunderstood
OnigResult.LengthAtto be the count of code points instead of the byte count -- it being the byte count makes a lot more sense.I have added a regression test and removed
OnigString.utf16OffsetIsCodePointEndwhich is no longer needed.@EvilBeaver discovered the issue in VS Code (microsoft/vscode#2170)