This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
See #347
Fixes #347
Description of the Change
After merging this PR, arm64 Linux Electron prebuilds will be created on a native arm64 host in Travis. This seems to be the only viable option for now, because apparently node-gyp doesn't support cross-compilation for other platforms than Windows (it builds without errors, but the final
keytar.node
is i686).Alternate Designs
Possible Drawbacks
GitHub Actions doesn't support native arm64 hosted CI (yet), so the move from Travis to GH Actions might be a bit more painful after this change. Running a Docker container with QEMU emulation will work on GitHub Actions, but is much slower than a native arm64 host.
Verification Process
Release Notes
Repair arm64 Linux Electron prebuilds