This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Improve sass grammar #175
Merged
Improve sass grammar #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need specs. |
|
Due to unit fail I've discarded property-value change. Basically it was a small improvement in regex to not act greedy with white spaces in variables.
|
|
✅ Success: The Travis CI build passed I'll be back on Tuesday so if you could write specs I'd appreciate it. |
|
Added specs. |
| @@ -338,6 +529,7 @@ | |||
| ] | |||
| 'property-value': | |||
| 'begin': '(:)?\\s?+' | |||
| # 'begin': '(:)?(?=\\S+)' # discard due unit fail | |||
There was a problem hiding this comment.
It's a future fix and I've written about it in 3rd comment.
There was a problem hiding this comment.
If it's for a future fix, please remove this from this PR.
|
@50Wliu |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for missing at-rules in sass.cson (#171)