This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix inline comment in method signature #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@50Wliu @noseglid please review. |
|
I'd add checks for the surrounding tokens to ( |
|
@noseglid thanks. Will do. |
|
@noseglid addressed your comment. |
|
👍 LGTM |
| @@ -884,6 +884,9 @@ | |||
| 'patterns': [ | |||
| { | |||
| 'include': '#parameters' | |||
| }, | |||
|
@50Wliu fixed your comment, could you review again? |
|
Thanks! |
|
@50Wliu @noseglid thank you for reviewing and merging PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bug with displaying inline comment that is mixed with method parameters + when there is just comment without method parameters, test cases are shown below:
Change is just adding
comments-inlineto the list of patterns to check inmethods.Fixes #60.