This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main problem is the identification of variables.
It was too lenient in the first take because it didn't require the a space to exist (e.g. between
int
andname
inint name;
).I am not super happy with the current solution (repeating the "generics, dots, commas blalba" regex and check for a space in between), but I'm at a loss for better alternatives. The way it was before didn't work with generics (see comment in #47). At least this works in all cases.
The issue in #47 is different with this PR. E.g. example (row 13) below gets
meta.definition.variable.java storage.type.java
onRectangle2D
(correct)meta.definition.variable.java punctuation.separator.period.java
on.
(correct)meta.definition.variable.java variable.other.property.java
onDouble
(while correct, I'd like to sestorage.type.java
here too)meta.definition.variable.java variable.other.definition.java
ond
(correct)So much better, just a minor wrinkle to iron out.
Example: