Improve the support for :lang() #89
Conversation
About entity.other.attribute-name.pseudo-class.ui-state.css, * the name is not accurate in that it equates UI with input controls * some items (e.g., :required) are not about state therefore it cannot be justified to be a separate entry.
* Subtags can be consisted of digits. https://tools.ietf.org/html/bcp47#page-1-5 * Language ranges contains asterisks must be quoted as strings. https://drafts.csswg.org/selectors-4/#language-range * "Empty subtags" are allowed. https://bugs.webkit.org/attachment.cgi?id=246667&action=diff#a/LayoutTests/fast/css/parsing-css-lang.html_sec3
|
@50Wliu ready to 🔥 |
| 'end': '\\)' | ||
| 'endCaptures': | ||
| '0': | ||
| 'name': 'punctuation.section.function.css' | ||
| 'patterns': [ | ||
| { | ||
| 'include': '#selector' | ||
| 'match': '(?i)(?<=[(,\\s])[a-z]+(-[a-z0-9]*+)*+(?=[),\\s])' |
There was a problem hiding this comment.
I would prefer the explicit [A-Za-z] rather than doing it through (?i) here and below.
There was a problem hiding this comment.
Yeah, that would be better 😆
| link|target|visited # location | ||
| | active|focus|hover # user action | ||
| | default|disabled|enabled|read-only|read-write # input control state | ||
| | checked|indeterminate # input value state |
There was a problem hiding this comment.
Looks like we lose the extra .ui-state class here. Do you think that's important?
There was a problem hiding this comment.
As I said in the commit msg of ee52174, this name "ui-state" itself doesn't make sense, that's why I want to remove it. And I think it should be safe even for themes that are relying on this class coz the related properties will still get the "pseudo-class" class.
|
Do you think "meta.language-ranges.css" is necessary here? |
|
Thought I commented about that. I guess not. No, I don't think it's necessary. This isn't really something that can be autocompleted. |
The scope "meta.language-ranges.css" seems like unnecessary complexity, is it ok to remove it?