Rewrite id selector to be more standards-compliant #79

hediyi · 2016-08-25T08:50:23Z

No description provided.

winstliu · 2016-08-25T16:00:04Z

grammars/css.cson

        '''
        'name': 'entity.other.attribute-name.class.css'
      }
      {
        'captures':
          '1':
            'name': 'punctuation.definition.entity.css'
-        'match': '(#)[a-zA-Z][a-zA-Z0-9_-]*'
+        'match': '''(?x)
+          (\\#)


No need for escape

It's true that # usually doesn't need escaping. But in extended mode (?x), # becomes a metacharacter, denoting the start of a comment—if you don't escape it, the following ) will be interpreted as comment.

<id-selector> = <hash-token> with the restriction that the <hash-token>'s value must be an identifier, which has the same syntax as <ident-token>: * may contain only * [a-zA-Z0-9_-] * ISO 10646 characters U+00A0 and higher * must not begin with [0-9] * must not begin with '-' followed by [0-9] * must be at least 2 characters long if begins with '-'

winstliu reviewed Aug 25, 2016
View reviewed changes

hediyi added 2 commits August 26, 2016 09:01

Rewrite the pattern of id selector

b484421

winstliu merged commit 42679c6 into atom:master Aug 26, 2016

hediyi deleted the rewrite-id-selector branch August 26, 2016 02:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rewrite id selector to be more standards-compliant #79

Rewrite id selector to be more standards-compliant #79

hediyi commented Aug 25, 2016

winstliu Aug 25, 2016

hediyi Aug 25, 2016

winstliu Aug 25, 2016

Rewrite id selector to be more standards-compliant #79

Rewrite id selector to be more standards-compliant #79

Conversation

hediyi commented Aug 25, 2016

winstliu Aug 25, 2016

Choose a reason for hiding this comment

hediyi Aug 25, 2016

Choose a reason for hiding this comment

winstliu Aug 25, 2016

Choose a reason for hiding this comment