Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

fix: Support auto-import for annotations #120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mdiin
Copy link
Contributor

@mdiin mdiin commented Feb 18, 2020

Identify the Bug

#114

Description of the Change

atom-languageclient considers interfaces as being of type mixin, and (many?) annotations are interfaces. Since buildImportSuggestion does not handle the mixin type interfaces cannot be auto-imported.

This change treats interfaces same as classes, which seems to me is the correct behaviour, seeing as interfaces are types without an implementation.

Alternate Designs

I did not consider alternate designs, although I am open to discussion about this fix.

Possible Drawbacks

I see no obvious drawbacks.

Verification Process

  • Trigger imports of various types

Release Notes

Fixed an issue where auto-import of interfaces would fail.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant