This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
#114
Description of the Change
atom-languageclient considers interfaces as being of type
mixin
, and (many?) annotations are interfaces. SincebuildImportSuggestion
does not handle themixin
type interfaces cannot be auto-imported.This change treats interfaces same as classes, which seems to me is the correct behaviour, seeing as interfaces are types without an implementation.
Alternate Designs
I did not consider alternate designs, although I am open to discussion about this fix.
Possible Drawbacks
I see no obvious drawbacks.
Verification Process
Release Notes
Fixed an issue where auto-import of interfaces would fail.