Merge pull request #1435 from atom/aw/stop-selection-sync

Reset mouseSelectionInProgress synchronously on mouseUp
atom · May 4, 2018 · fbaf0d4 · fbaf0d4
2 parents dff74ba + 324e08c
commit fbaf0d4
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/views/staging-view.js b/lib/views/staging-view.js
@@ -778,15 +778,17 @@ export default class StagingView extends React.Component {
   }
 
   async mouseup() {
+    const hadSelectionInProgress = this.mouseSelectionInProgress;
+    this.mouseSelectionInProgress = false;
+
     await new Promise(resolve => {
       this.setState(prevState => ({
         selection: prevState.selection.coalesce(),
       }), resolve);
     });
-    if (this.mouseSelectionInProgress) {
+    if (hadSelectionInProgress) {
       this.debouncedDidChangeSelectedItem(true);
     }
-    this.mouseSelectionInProgress = false;
   }
 
   undoLastDiscard() {