This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Make fast mode the default mode and remove prompt #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we haven't got any major negative feedback during the opt-in period of the fast mode (more info here), and the performance results are extremely positive from people opting in: between 5X and 15X faster depending on the project size:
Based on that, we've decided to make the fast mode the default mode on fuzzy finder and remove the opt-in prompt. We're going to leave the config options to allow user to revert to the old behaviour for a while, just to get some time for some potential obscure edge cases to pop out.
I'm planning to release a new version of the fuzzy finder once this PR gets merged and cherry pick the new version into the Atom v1.39 release