Ignore VCS directories even when they are not in ignoreNames

[aviatesk]

Hi, this is my very first PR for Atom's core system ! 😁

Rationale

If an user's core.ignoredNames is modified so that it doesn't include .git or .hg (they are included by default) but still core.excludeVcsIgnoredPaths is true, then the new fast mode using ripgrep will show files in those directories (like HEAD, COMMIT_EDITMSG and so on).

Because those files are usually regarded as VCS-ignored files and more over, the previous alternative mode does exclude those files when core.excludeVcsIgnoredPaths is true, I believe these files are better to be ignored in fast mode as well.

Please refer to #379 (comment) for more detail.

Description of the Change

Only 5 line changes: Add ripgrep arguments to exclude those files when core.excludeVcsIgnoredPaths is true.

Possible Drawbacks

To include those files, an user need to disable both core.ignoredNames and core.excludeVcsIgnoredPaths, and it might be confusing ?

[rafeca]

Wow, this was fast!! Thanks a lot for the PR! 😍

Don't worry about the failure on travis, it's not caused by this PR.

Can you also add a test, so this behaviour does not get broken in the future? You can add it just below this test:

fuzzy-finder/spec/fuzzy-finder-spec.js

Lines 1659 to 1672 in f8e0cb1

	describe('when the .gitignore matches parts of the path to the root folder', () => {
	beforeEach(() => {
	const ignoreFile = path.join(projectPath, '.gitignore')
	fs.writeFileSync(ignoreFile, path.basename(projectPath))
	})
	it('only applies the .gitignore patterns to relative paths within the root folder', async () => {
	await projectView.toggle()
	await waitForPathsToDisplay(projectView)
	expect(Array.from(projectView.element.querySelectorAll('li')).find(a => a.textContent.includes('file.txt'))).toBeDefined()
	})
	})

You can use that test as an inspiration, and do something like atom.config.set('core.ignoredNames', []) at the beginning to be sore that the ignoredNames param does not have the .git folder in it.

To include those files, an user need to disable both core.ignoredNames and core.excludeVcsIgnoredPaths, and it might be confusing ?

I think it's such a rare case to want to search inside the .git folder that this should be fine. Alternatively once this PR lands we can remove the .git folder from the core.ignoredNames default value.

[aviatesk]

I'm welcome to write specs ! 😄
Not too much sure about writing specs, but there seem a lot of examples in fuzzy-finder, thus I may make it through. Thanks for your kind mentoring !

I think it's such a rare case to want to search inside the .git folder that this should be fine. Alternatively once this PR lands we can remove the .git folder from the core.ignoredNames default value.

Yeah, I totally agree with you and the alternative also sounds sane.

[aviatesk]

@rafeca
I added the spec just now !
On my local machine, I confirmed this PR can pass but the current master branch fails the spec I've just added.

I've not created a spec for the case when core.excludeVcsIgnoredPaths is set to false, since I thought it would make specs more verbose.
But if you want, I'm okay to add a spec for the case 😃

[rafeca]

This is awesome! ❤️

Thanks a lot for this PR, and congratulations for your first contribution to Atom! I hope that many more will come afterwards 😃

I'm going to merge it and publish a new version of the fuzzy finder package. This fix will probably be available on v1.39 (since I'll cherry-pick this along some other stuff from fuzzy finder to the current beta).

[aviatesk]

Thanks again for your help !

I'm really happy to be able to contribute to Atom, my favourite editor, and yeah, will make more in the future ! 😁

Looking forward to the next release !