This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Increase timeout for atom-application.test.js on CI #19523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Azure and Travis, we recently started observing a few test failures in atom-application.test.js. After staring at those tests for a bit, it doesn't seem like they are failing due to a race condition. Instead, it is possible that these tests are simply timing out due to CI containers sometimes being overloaded and, thus, slower. I tested this hypothesis locally by running tests on a VM while stress-testing the host machine. Tests would eventually have passed, but they timed out before having the chance to do so. This commit increases the timeout on CI to 10 seconds for `AtomApplication` tests in an attempt to fix the spurious failures we were observing. This is similar to what we've historically done for renderer process tests (see https://github.com/atom/atom/blob/7faea50190a8c6738b6ecee105645ee274a32b6e/spec/spec-helper.coffee#L50).
jasonrudolph
approved these changes
Jun 13, 2019
jasonrudolph
added a commit
that referenced
this pull request
Jun 13, 2019
Increase timeout for atom-application.test.js on CI
|
atom-application.test.js บน CI #19523 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19512
On Azure and Travis, we recently started observing a few test failures in atom-application.test.js.
After staring at those tests for a bit, it doesn't seem like they are failing due to a race condition. Instead, it is possible that these tests are simply timing out due to CI containers sometimes being overloaded and, thus, slower. I tested this hypothesis locally by running tests on a VM while stress-testing the host machine. Tests would eventually have passed, but they timed out before having the chance to do so.
This commit increases the timeout on CI to 10 seconds for
AtomApplicationtests in an attempt to fix the spurious failures we were observing. This is similar to what we've historically done for renderer process tests (see spec/spec-helper.coffee).