This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Avoid adding non-existent project directories #12694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Sobo <[email protected]>
Signed-off-by: Nathan Sobo <[email protected]>
Signed-off-by: Nathan Sobo <[email protected]>
Signed-off-by: Nathan Sobo <[email protected]>
Like deserializers and config schema, directory providers are added at package load time, and *not* removed when the package is deactivated
maxbrunsfeld
force-pushed
the
mb-ns-avoid-adding-non-existent-project-directories
branch
from
c5d0c17 to
e444076
Compare
nathansobo
force-pushed
the
mb-ns-avoid-adding-non-existent-project-directories
branch
from
212cb0d to
7c7460e
Compare
nathansobo
force-pushed
the
mb-ns-avoid-adding-non-existent-project-directories
branch
from
7c7460e to
7bba3e8
Compare
|
Still having a rough time on Travis. I tried changing |
Signed-off-by: Nathan Sobo <[email protected]>
Signed-off-by: Nathan Sobo <[email protected]>
…non-existent-project-directories
See electron/electron#7278 Signed-off-by: Nathan Sobo <[email protected]>
Signed-off-by: Nathan Sobo <[email protected]>
Signed-off-by: Nathan Sobo <[email protected]>
|
OK, finally all 🍏. Gonna re-run the travis and appveyor builds one time extra, just to be sure. |
maxbrunsfeld
deleted the
mb-ns-avoid-adding-non-existent-project-directories
branch
|
✨✨✨ |
This was referenced Oct 9, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10297
Depends on atom/service-hub#9
/cc @peterhal @nmote @mostafaeweda
This implements the plan we described in #10297 (comment). This means that Nuclide's
atom.directory-providerservice hook will be called earlier in Atom's startup process, before project deserialization and notably before Nuclide'sactivatemethod is called. It also means that customDirectoryinstances for which.existsSync()returnsfalsewill not be added to the project, so you may need to handle the state where the user has not yet authenticated specially in that method.Also note that the
atom.directory-providerservice must be specified in Nuclide's top-level package.json (rather than being registered dynamically) in order to be recognized.Sorry for requiring you to make these changes, but we really need to fix #10297, which was introduced by changes that we made together in order to accommodate Nuclide in the first place, so it doesn't seem too unreasonable.