Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Previously, the atmoz/sftp docker image had an empty directory at
/etc/ssh/sshd_config.d/
, which I thought I could add configuration to and have it applied to sshd. (This is a common pattern for unix services).However, the default sshd_config file included in this project does not include those subfiles, so any config files added there are not respected.
After
Now with this change, files added in this directory are applied.
Example
For example, adding a file at
/etc/ssh/sshd_config.d/ancient_kex_algorithm.conf
with contents like this:now allows me to test an insecure KexAlgorithms mode.
It's better to do this with one file, vs store a copy of
sshd_config
with my tweaks, so that I can pick up any future changes to thesshd_config
file coming from this repo.