New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Logging of UserName,Passwords as Arguments #362 #363

Closed

vkg23 wants to merge 1 commit into atmoz:master from vkg23:patch-1

vkg23 commented Feb 22, 2023

Fix for #362 i reported earlier.
Do let me know if any comments.

Action: Removed Logging of UserName,Passwords as Arguments ($1)


          Removed Logging of UserName,Passwords as Arguments atmoz#362

05c9ce8

vkg23 mentioned this pull request

User Names and Passwords exposed in Logs #362

Open

Owner

atmoz commented Feb 25, 2023

Parsing user data: looks broken, you just removed everything after :. It's no longer a helpful log statement.

I understand the argument to hide passwords from the log. But at least print the username.

atmoz closed this

kimdre mentioned this pull request

Hide password in userdata parser logs #367

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet