google authentication #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSinseswa721
requested review from
mukunzidd,
maxCastro1,
elijahladdie,
MC-Knight,
aimedivin,
faid-terence,
UwicyezaG,
Ndevu12 and
Calebgisa72
GSinseswa721
force-pushed
the
feature-google-authentication
branch
from
d1cabbd
to
2cc6e76
Compare
Pull Request Test Coverage Report for Build 9156518173Details
💛 - Coveralls |
GSinseswa721
force-pushed
the
feature-google-authentication
branch
from
2cc6e76
to
5df9b11
Compare
|
@GSinseswa721 resolve the conflict and tests are decreasing ! |
GSinseswa721
force-pushed
the
feature-google-authentication
branch
from
5df9b11
to
ccad3a9
Compare
elijahladdie
force-pushed
the
feature-google-authentication
branch
2 times, most recently
from
716bbf8
to
59987b4
Compare
elijahladdie
approved these changes
May 17, 2024
GSinseswa721
force-pushed
the
feature-google-authentication
branch
2 times, most recently
from
9bd8d75
to
6c7bf4f
Compare
maxCastro1
approved these changes
May 19, 2024
faid-terence
requested changes
May 19, 2024
There was a problem hiding this comment.
@GSinseswa721 remove the console.log(".................")
There was a problem hiding this comment.
@GSinseswa721 Remove as any on middlewares , using any we're not utilising power of typescript.
There was a problem hiding this comment.
@GSinseswa721
Remove as any on middlewares !
GSinseswa721
force-pushed
the
feature-google-authentication
branch
from
6c7bf4f
to
6aa2cd7
Compare
faid-terence
requested changes
May 20, 2024
There was a problem hiding this comment.
@GSinseswa721 remove unnecessary commented codes.
GSinseswa721
force-pushed
the
feature-google-authentication
branch
from
6aa2cd7
to
c833a1f
Compare
faid-terence
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is all about Google OAuth authentication for user sign in.
It configures Passport.js to utilize the Google OAuth strategy, allowing users to log in using their Google accounts.
Description of Task to be completed
Configuring Passport.js with Google OAuth strategy.
Implement routes for Google sign-in and callback handling.
Authenticate users using Google profile information.
How should this be manually tested?