Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing console and sensitive data in reponse #80

Merged
merged 1 commit into from
May 15, 2024

Conversation

elijahladdie
Copy link
Contributor

@elijahladdie elijahladdie commented May 14, 2024

What does this PR do?

This Pull request contain the updated response on getting recommended products and console removed within source code.

Description of Task to be completed?

  • debugged and tested functionality for retrieve recommended products using vendor/category from database.

How should this be manually tested?

git clone  https://github.com/atlp-rwanda/knights-ecomm-be.git
cd knights-ecomm-be
git checkout fix-remove-console
npm i
npm run dev

@elijahladdie elijahladdie self-assigned this May 14, 2024
@elijahladdie elijahladdie added the backend Good for newcomers label May 14, 2024
@elijahladdie elijahladdie added this to the Product Management milestone May 14, 2024
@coveralls
Copy link

coveralls commented May 14, 2024

Pull Request Test Coverage Report for Build 9098020168

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 79.107%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/services/productServices/getRecommendedProductsService.ts 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
src/services/productServices/getRecommendedProductsService.ts 1 57.78%
Totals Coverage Status
Change from base Build 9096344112: -0.02%
Covered Lines: 842
Relevant Lines: 989

💛 - Coveralls

@faid-terence
Copy link
Collaborator

@elijahladdie
Write a PR description !

@elijahladdie
Copy link
Contributor Author

@elijahladdie Write a PR description !

@faid-terence Done!

Copy link
Collaborator

@faid-terence faid-terence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work @elijahladdie !

@faid-terence faid-terence merged commit 562dec0 into develop May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants