Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding reset password feature #54

Merged
merged 2 commits into from
May 7, 2024
Merged

adding reset password feature #54

merged 2 commits into from
May 7, 2024

Conversation

elijahladdie
Copy link
Contributor

@elijahladdie elijahladdie commented May 2, 2024

Acceptance Criteria

  • Implement a password reset request API endpoint
  • Validate the user's email or account identifier
  • Generate and send a secure password reset token (e.g., via email)
  • Implement a password reset confirmation API endpoint
  • Validate the password reset token
  • Update the user's password with a new, securely hashed password
  • Implement appropriate error handling and responses
  • Implement input sanitization

Copy link

gitguardian bot commented May 2, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@elijahladdie elijahladdie added this to the Authentication and RBAC milestone May 2, 2024
@elijahladdie elijahladdie linked an issue May 2, 2024 that may be closed by this pull request
8 tasks
@elijahladdie elijahladdie added backend Good for newcomers In Progress This Label will be added on pending task labels May 2, 2024
@elijahladdie elijahladdie self-assigned this May 2, 2024
@coveralls
Copy link

coveralls commented May 2, 2024

Pull Request Test Coverage Report for Build 8980463870

Details

  • 43 of 62 (69.35%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.1%) to 73.488%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/services/userServices/sendResetPasswordLinkService.ts 13 20 65.0%
src/services/userServices/userPasswordResetService.ts 15 27 55.56%
Totals Coverage Status
Change from base Build 8968989467: -1.1%
Covered Lines: 353
Relevant Lines: 440

💛 - Coveralls

@elijahladdie elijahladdie force-pushed the ft-reset-password branch 3 times, most recently from 8c643ad to e6a3e7c Compare May 3, 2024 00:01
@elijahladdie elijahladdie added Ready for reviews Pull request is ready for review and removed In Progress This Label will be added on pending task labels May 3, 2024
Copy link
Collaborator

@faid-terence faid-terence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elijahladdie
Please remove the console.logs !!

ormconfig.js Outdated Show resolved Hide resolved
@faid-terence
Copy link
Collaborator

@elijahladdie
Resolve the conflicts !!

@faid-terence
Copy link
Collaborator

Screenshot from 2024-05-05 23-59-57

Add more test for these services

@elijahladdie elijahladdie force-pushed the ft-reset-password branch 2 times, most recently from 8f69fbb to b3b273d Compare May 6, 2024 09:52
@elijahladdie elijahladdie force-pushed the ft-reset-password branch 7 times, most recently from 4029cf5 to 110219f Compare May 6, 2024 15:54
@faid-terence faid-terence added the Highest priority Has more priority label May 6, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the AUTH_PASSWORD= variable

@faid-terence faid-terence self-requested a review May 7, 2024 07:23
Copy link
Collaborator

@faid-terence faid-terence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! @elijahladdie

@faid-terence faid-terence merged commit 70e33ad into develop May 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Good for newcomers Highest priority Has more priority Ready for reviews Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: User Password Reset
7 participants