Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix user profile managment #124

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

MC-Knight
Copy link
Contributor

What does this PR do?

This pull request fix profile management for both vendor and admin

Description of Task to be completed?

endpoints for

  • User can change profile picture
  • User can change his/her basic information

How should this be manually tested?

```
cd knights-ecomm-be  
git fetch
git checkout fix-profile-managment
npm i
npm run dev
```

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10008610017

Details

  • 38 of 53 (71.7%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 90.399%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/services/userServices/userDisableTwoFactorAuth.ts 5 6 83.33%
src/services/userServices/userEnableTwoFactorAuth.ts 5 6 83.33%
src/services/userServices/getUserProfile.ts 8 10 80.0%
src/services/userServices/userUpdateProfileImage.ts 15 26 57.69%
Totals Coverage Status
Change from base Build 9973107170: -0.5%
Covered Lines: 1544
Relevant Lines: 1648

💛 - Coveralls

@faid-terence faid-terence self-requested a review July 19, 2024 15:12
Copy link
Collaborator

@faid-terence faid-terence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Approved !
@MC-Knight

@faid-terence faid-terence merged commit d0dfd92 into develop Jul 19, 2024
3 checks passed
maxCastro1 pushed a commit that referenced this pull request Jul 24, 2024
maxCastro1 pushed a commit that referenced this pull request Jul 25, 2024
faid-terence added a commit that referenced this pull request Jul 25, 2024
Merge pull request #124 from atlp-rwanda/fix-user-profile-management
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants