Application Skeleton Implementation #195
Open
+1,592
−1,353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Ismaelmurekezi
approved these changes
Oct 11, 2024
SaddockAime
approved these changes
Oct 11, 2024
mugishaj092
approved these changes
Oct 11, 2024
Ishimwe7
added
Ready For Merge
and removed
Ready For Review
ncutixavier
reviewed
Oct 14, 2024
Comment on lines
26
to
29
| // useEffect(() => { | ||
| // props.getAllCycles(); | ||
| // }, []); | ||
|
|
There was a problem hiding this comment.
Get rid of all unnecessary comments
src/pages/TrainneeDetails.tsx
Outdated
| @@ -20,6 +21,7 @@ const TrainneeDetails = (props: any) => { | |||
| }, [ID]); | |||
|
|
|||
| const traineeDetails = oneTraineeDetails.data; | |||
| console.log("Trainee: ", traineeDetails); | |||
Ishimwe7
force-pushed
the
ft-skeleton-implementation
branch
from
6a620ea
to
d34ee76
Compare
|
Code Climate has analyzed commit d34ee76 and detected 0 issues on this pull request. View more on Code Climate. |
|
This PR has conflicts |
Let me resolve them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces skeleton loading components throughout the application to improve user experience by providing visual feedback during data fetching. These skeleton loaders mimic the structure of the final content, making the interface more intuitive and responsive while the content is loading.
Description of Task Completed
Related Issue
#161