Code

Moving between lists#73

Code

Merged

alexreardon merged 135 commits intomasteratlassian/react-beautiful-dnd:masterfrom moving-between-listsatlassian/react-beautiful-dnd:moving-between-listsCopy head branch name to clipboardSep 14, 2017

+7,795-2,499

Commits

Commits on Aug 25, 2017

• add story for dragging between two vertical lists

  jaredcrowe

  committed
  c3cdb8f

  Copy full SHA for c3cdb8f

• add story for dragging between two vertical lists (#58)

  

  jaredcrowe

  authored and

  alexreardon

  committed
  cb38e79

  Copy full SHA for cb38e79

• work in progress (#59)

  alexreardon

  authored
  ce9f997

  Copy full SHA for ce9f997

• more progress (#60)

  alexreardon

  authored
  1f9640c

  Copy full SHA for 1f9640c

Commits on Aug 27, 2017

• wip

  alexreardon

  committed
  ceee569

  Copy full SHA for ceee569

• action creator plumbing

  alexreardon

  committed
  32d2e62

  Copy full SHA for 32d2e62

• more refinement

  alexreardon

  committed
  ee6a4de

  Copy full SHA for ee6a4de

• adding complexity to stories

  alexreardon

  committed
  4ca11ac

  Copy full SHA for 4ca11ac

Commits on Aug 28, 2017

• WIP

  jaredcrowe

  committed
  545a9ae

  Copy full SHA for 545a9ae

• Merge branch 'multiple-vertical-lists' into moving-between-lists

  jaredcrowe

  committed
  8a01ec6

  Copy full SHA for 8a01ec6

• improving get-best-cross-axis-droppable

  alexreardon

  committed
  27e6694

  Copy full SHA for 27e6694

• Merge branch 'moving-between-lists' of github.com:atlassian/react-beautiful-dnd into moving-between-lists

  jaredcrowe

  committed
  61ec7ee

  Copy full SHA for 61ec7ee

• almost moving to the right place

  alexreardon

  committed
  095e23e

  Copy full SHA for 095e23e

• hacking something together

  alexreardon

  committed
  9b4e414

  Copy full SHA for 9b4e414

• initial placeholder

  alexreardon

  committed
  53cbf60

  Copy full SHA for 53cbf60

• implement mouse dragging between lists, fix tests.

  jaredcrowe

  committed
  6b21ff2

  Copy full SHA for 6b21ff2

• Merge branches 'moving-between-lists' and 'moving-between-lists' of github.com:atlassian/react-beautiful-dnd into moving-between-lists

  jaredcrowe

  committed
  f6c4139

  Copy full SHA for f6c4139

• fixes

  alexreardon

  committed
  b1dd265

  Copy full SHA for b1dd265

• Merge branch 'moving-between-lists' of github.com:atlassian/react-beautiful-dnd into moving-between-lists

  alexreardon

  committed
  a2dd115

  Copy full SHA for a2dd115

• adding scroll container

  alexreardon

  committed
  1fd2fdb

  Copy full SHA for 1fd2fdb

• wip

  alexreardon

  committed
  5fcbc7f

  Copy full SHA for 5fcbc7f

• fixing performance issue when moving to a new droppable

  alexreardon

  committed
  0bf8c23

  Copy full SHA for 0bf8c23

• adding explaination and tests for optional patch value

  alexreardon

  committed
  e2d2c23

  Copy full SHA for e2d2c23

Commits on Aug 29, 2017

• re-write getNewHomeClientOffset and fix tests

  jaredcrowe

  committed
  be3012c

  Copy full SHA for be3012c

• Merge branch 'moving-between-lists' of github.com:atlassian/react-beautiful-dnd into moving-between-lists

  jaredcrowe

  committed
  533cf5b

  Copy full SHA for 533cf5b

• wip

  alexreardon

  committed
  1f00de0

  Copy full SHA for 1f00de0

• Merge branch 'moving-between-lists' of github.com:atlassian/react-beautiful-dnd into moving-between-lists

  alexreardon

  committed
  28950dd

  Copy full SHA for 28950dd

• fix drag impact when dragging between multiple lists with internal scrolling

  jaredcrowe

  committed
  b37f77b

  Copy full SHA for b37f77b

• fix minor type error in action-creators

  jaredcrowe

  committed
  fe2dc65

  Copy full SHA for fe2dc65

• move-to-edge

  alexreardon

  committed
  fa47b64

  Copy full SHA for fa47b64

• Merge branch 'moving-between-lists' of github.com:atlassian/react-beautiful-dnd into moving-between-lists

  alexreardon

  committed
  4ce37d7

  Copy full SHA for 4ce37d7

• Merge branch 'moving-between-lists' of github.com:atlassian/react-beautiful-dnd into moving-between-lists

  jaredcrowe

  committed
  e6ed7cd

  Copy full SHA for e6ed7cd

• making source a fragment

  alexreardon

  committed
  e91cbfe

  Copy full SHA for e91cbfe

• better keyboard transitions

  alexreardon

  committed
  ca9568d

  Copy full SHA for ca9568d

• Merge branch 'moving-between-lists' of github.com:atlassian/react-beautiful-dnd into moving-between-lists

  jaredcrowe

  committed
  9981831

  Copy full SHA for 9981831

• getNewHomeClientOffset works for all multiple vertical cases. tidy function and add types

  jaredcrowe

  committed
  c8bff8b

  Copy full SHA for c8bff8b

• wip

  alexreardon

  committed
  4d7bf24

  Copy full SHA for 4d7bf24

• Merge branch 'moving-between-lists' of github.com:atlassian/react-beautiful-dnd into moving-between-lists

  alexreardon

  committed
  cfac61d

  Copy full SHA for cfac61d

• wip tests

  alexreardon

  committed
  ac8f28f

  Copy full SHA for ac8f28f

Commits on Aug 30, 2017

• Merge branch 'master' of github.com:atlassian/react-beautiful-dnd into moving-between-lists

  alexreardon

  committed
  dadafdb

  Copy full SHA for dadafdb

• adding tests for move-to-edge

  alexreardon

  committed
  7628ea2

  Copy full SHA for 7628ea2

• refactor getNewHomeClientOffset tests to make life easier when adding multiple-list tests

  jaredcrowe

  committed
  b030294

  Copy full SHA for b030294

• Merge branch 'moving-between-lists' of github.com:atlassian/react-beautiful-dnd into moving-between-lists

  jaredcrowe

  committed
  dca5858

  Copy full SHA for dca5858

Commits on Aug 31, 2017

• refactoring keyboard movement - wip

  alexreardon

  committed
  a1f0e4f

  Copy full SHA for a1f0e4f

Commits on Sep 1, 2017

• add tests for updated getNewHomeClientOffset function. add client dimensions to DroppableDimension shape.

  jaredcrowe

  committed
  8e2ab45

  Copy full SHA for 8e2ab45

• Merge branch 'moving-between-lists' of github.com:atlassian/react-beautiful-dnd into moving-between-lists

  alexreardon

  committed
  6128a35

  Copy full SHA for 6128a35

• Merge branch 'master' of github.com:atlassian/react-beautiful-dnd into moving-between-lists

  alexreardon

  committed
  0e525a4

  Copy full SHA for 0e525a4

Commits on Sep 4, 2017

• wip

  alexreardon

  committed
  dc485a3

  Copy full SHA for dc485a3

• dragging with a keyboard now uses edges

  alexreardon

  committed
  18f1622

  Copy full SHA for 18f1622

• minor enchancement to hooks integration test

  alexreardon

  committed
  d267a78

  Copy full SHA for d267a78

• fixing jump to next index tests

  alexreardon

  committed
  e8f5cd8

  Copy full SHA for e8f5cd8

• fixing remaining jump-to-next-index tests

  alexreardon

  committed
  95c96ca

  Copy full SHA for 95c96ca

Commits on Sep 5, 2017

• spiking

  alexreardon

  committed
  b63cd2a

  Copy full SHA for b63cd2a

• work in progress

  alexreardon

  committed
  1631663

  Copy full SHA for 1631663

• it works

  alexreardon

  committed
  6d20289

  Copy full SHA for 6d20289

• wip

  alexreardon

  committed
  7b779ae

  Copy full SHA for 7b779ae

• logging

  alexreardon

  committed
  fd05533

  Copy full SHA for fd05533

• seperating jump to index functions for my sanity

  alexreardon

  committed
  04c1ca8

  Copy full SHA for 04c1ca8

Commits on Sep 6, 2017

• removing unneeded property

  alexreardon

  committed
  910b229

  Copy full SHA for 910b229

• working on re entering into home list after transition

  alexreardon

  committed
  9a4ac81

  Copy full SHA for 9a4ac81

• wip

  alexreardon

  committed
  5fd90b2

  Copy full SHA for 5fd90b2

• refactoring move-to-new-droppable

  alexreardon

  committed
  c18b833

  Copy full SHA for c18b833

• returning to home list now working much better

  alexreardon

  committed
  0fdde59

  Copy full SHA for 0fdde59

• making the order of the moved array consistant between files

  alexreardon

  committed
  a146a0b

  Copy full SHA for a146a0b

• updating stories

  alexreardon

  committed
  3dead3d

  Copy full SHA for 3dead3d

• fixing story

  alexreardon

  committed
  a883716

  Copy full SHA for a883716

• trying to get scroll working

  alexreardon

  committed
  beb995a

  Copy full SHA for beb995a

• more example data

  alexreardon

  committed
  c7e19c5

  Copy full SHA for c7e19c5

• now handling window scroll correctly for keyboard movements

  alexreardon

  committed
  177d71e

  Copy full SHA for 177d71e

Commits on Sep 7, 2017

• fixing incorrect impact order when moving back to home list when moving before home location

  alexreardon

  committed
  434abf5

  Copy full SHA for 434abf5

• adding isEnabled flag

  alexreardon

  committed
  6f3cd06

  Copy full SHA for 6f3cd06

• Merge branch 'master' into moving-between-lists

  alexreardon

  committed
  714be5b

  Copy full SHA for 714be5b

• new client offset now works correctly for keyboard dragging

  alexreardon

  committed
  e218a0d

  Copy full SHA for e218a0d

• fixing mouse movement

  alexreardon

  committed
  7d6a2c8

  Copy full SHA for 7d6a2c8

• fixing existing jump to next tests

  alexreardon

  committed
  b3b39a0

  Copy full SHA for b3b39a0

• improving tests

  alexreardon

  committed
  8c0e972

  Copy full SHA for 8c0e972

• jump to next index tests are looking good

  alexreardon

  committed
  5316f9c

  Copy full SHA for 5316f9c

• fixing broken get-drag-impact tests

  alexreardon

  committed
  b9c5609

  Copy full SHA for b9c5609

• starting work on get-best-droppable tests

  alexreardon

  committed
  48f7c5a

  Copy full SHA for 48f7c5a

• renmaing jump to next to move to next

  alexreardon

  committed
  8af5a4e

  Copy full SHA for 8af5a4e

• removing temp type addition

  alexreardon

  committed
  c97a48c

  Copy full SHA for c97a48c

Commits on Sep 8, 2017

• adding tests for get-best-cross-axis-droppable

  alexreardon

  committed
  dae315e

  Copy full SHA for dae315e

• adding tests for get-closest-draggable

  alexreardon

  committed
  4bd60f7

  Copy full SHA for 4bd60f7

• adding horizontal tests to get-closest-draggable

  alexreardon

  committed
  1a09d3f

  Copy full SHA for 1a09d3f

• Jaredcrowe/moving lists disabled droppables (#80)

  Show description for 3e13b31
  jaredcrowe

  authored
  3e13b31

  Copy full SHA for 3e13b31

• get-closest-draggable now uses a loop to check axis

  alexreardon

  committed
  3fb9a5f

  Copy full SHA for 3fb9a5f

• Merge branch 'moving-between-lists' of github.com:atlassian/react-beautiful-dnd into moving-between-lists

  alexreardon

  committed
  173fe78

  Copy full SHA for 173fe78

• get-closest-draggable now considers the droppables scroll

  alexreardon

  committed
  41e9ebc

  Copy full SHA for 41e9ebc

• container scroll now cancels a keyboard drag

  alexreardon

  committed
  c59e57b

  Copy full SHA for c59e57b

• progress

  alexreardon

  committed
  5f5243f

  Copy full SHA for 5f5243f

• renaming move-to-best-droppable to move-cross-axis

  alexreardon

  committed
  6a7a1cc

  Copy full SHA for 6a7a1cc

• adding tests

  alexreardon

  committed
  9389db5

  Copy full SHA for 9389db5

• adding more test cases to fill in

  alexreardon

  committed
  e3fe56f

  Copy full SHA for e3fe56f

Commits on Sep 10, 2017

• adding page visiblity checks

  alexreardon

  committed
  630d623

  Copy full SHA for 630d623

• now finding all options within a droppable

  alexreardon

  committed
  76c59d5

  Copy full SHA for 76c59d5

Commits on Sep 11, 2017

• correcting visiblity check for when inside a dimension

  alexreardon

  committed
  0011793

  Copy full SHA for 0011793

• disallowing container scroll while drag is occuring

  alexreardon

  committed
  0058fdc

  Copy full SHA for 0058fdc

• renaming allowScroll to isScrollAllowed

  alexreardon

  committed
  630564b

  Copy full SHA for 630564b

• add tests for dragging between lists to get-drag-impact.spec (#82)

  

  jaredcrowe

  authored and

  alexreardon

  committed
  88b5b39

  Copy full SHA for 88b5b39

• adding some tests

  alexreardon

  committed
  25a5401

  Copy full SHA for 25a5401

• Merge branch 'moving-between-lists' of github.com:atlassian/react-beautiful-dnd into moving-between-lists

  alexreardon

  committed
  dfa4bbd

  Copy full SHA for dfa4bbd

• renaming create-droppable

  alexreardon

  committed
  942307e

  Copy full SHA for 942307e

• cleaning up types in test util

  alexreardon

  committed
  937c068

  Copy full SHA for 937c068

• tests for is-within-visible-bounds-of-droppable

  alexreardon

  committed
  372195b

  Copy full SHA for 372195b

• tests for move-to-new-droppable

  alexreardon

  committed
  6070b18

  Copy full SHA for 6070b18

• adding horizontal tests for move-to-new-droppable

  alexreardon

  committed
  932de9f

  Copy full SHA for 932de9f

Commits on Sep 12, 2017

• adding test for droppable dimension clipping

  alexreardon

  committed
  e349ba7

  Copy full SHA for e349ba7

• fixing flow errors in test file

  alexreardon

  committed
  0bff636

  Copy full SHA for 0bff636

• adding child visibility check to move-cross-axis/index

  alexreardon

  committed
  da5d620

  Copy full SHA for da5d620

• adding placeholder validation to connected droppable tests

  alexreardon

  committed
  b6579c0

  Copy full SHA for b6579c0

• cleaning up tests

  alexreardon

  committed
  2165d79

  Copy full SHA for 2165d79

• adding tests for publishing whether a droppable is enabling during a drag

  alexreardon

  committed
  67b8895

  Copy full SHA for 67b8895

• placeholder tests for unnconnected droppable

  alexreardon

  committed
  c15cae1

  Copy full SHA for c15cae1

• adding cross axis move tests to drag handle

  alexreardon

  committed
  e5a2d4f

  Copy full SHA for e5a2d4f

• cross axis move tests for draggable

  alexreardon

  committed
  c7a25ce

  Copy full SHA for c7a25ce

• fixing flow errors

  alexreardon

  committed
  95367ff

  Copy full SHA for 95367ff

• initial impact now handled independently

  alexreardon

  committed
  18762e0

  Copy full SHA for 18762e0

• adding tests for impact for disabled droppables

  alexreardon

  committed
  e1a6fee

  Copy full SHA for e1a6fee

• more robust dimension clipping

  alexreardon

  committed
  d54cf87

  Copy full SHA for d54cf87

• fixing flow errors. moving get-client-rect to src

  alexreardon

  committed
  0e96515

  Copy full SHA for 0e96515

Commits on Sep 13, 2017

• adding tests for droppable dimension clipping

  alexreardon

  committed
  d46d330

  Copy full SHA for d46d330

• rearranging to follow AAA

  alexreardon

  committed
  6d535d6

  Copy full SHA for 6d535d6

• major refactor of get-client-offset

  alexreardon

  committed
  dcd114f

  Copy full SHA for dcd114f

• fixing linting and flow

  alexreardon

  committed
  f21a629

  Copy full SHA for f21a629

• reworking stories

  alexreardon

  committed
  3228ec2

  Copy full SHA for 3228ec2

• fixing stories

  alexreardon

  committed
  20c9d45

  Copy full SHA for 20c9d45

Commits on Sep 14, 2017

• fixing keyboard drop into empty list

  alexreardon

  committed
  c053acd

  Copy full SHA for c053acd

• major story refactoring

  alexreardon

  committed
  78029bc

  Copy full SHA for 78029bc

• adding checks for padding

  alexreardon

  committed
  b114b1c

  Copy full SHA for b114b1c

• droppable dimension is now padding aware

  alexreardon

  committed
  cfbd43f

  Copy full SHA for cfbd43f

• fixing import

  alexreardon

  committed
  5d58b25

  Copy full SHA for 5d58b25

• fixing flow issues

  alexreardon

  committed
  a580d3f

  Copy full SHA for a580d3f

• Merge branch 'master' of github.com:atlassian/react-beautiful-dnd into moving-between-lists

  alexreardon

  committed
  1b7db06

  Copy full SHA for 1b7db06

• updating docs

  alexreardon

  committed
  4c7b08b

  Copy full SHA for 4c7b08b

• more updates to readme

  alexreardon

  committed
  aa5ecbe

  Copy full SHA for aa5ecbe