Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot move with keyboard out of a isDropDisabled list #430

Closed
nmain opened this issue Apr 10, 2018 · 6 comments
Closed

Cannot move with keyboard out of a isDropDisabled list #430

nmain opened this issue Apr 10, 2018 · 6 comments
Assignees
Labels

Comments

@nmain
Copy link

nmain commented Apr 10, 2018

Bug or feature request?

Bug. Possibly related to issue #400, but doesn't seem to be the same thing. Unlike that issue, everything is contained on the page and there are no weird overflows.

Expected behavior

Moving items using the keyboard works.

Actual behavior

Console Error: Cannot handle keyboard movement event if direction is not provided

Steps to reproduce

Open this repro: https://codesandbox.io/s/qlxpwkl2xw
Move everything from the first list to the second list.
Then, using the keyboard, try to move an item from the second list back to the first list.

Browser version

Chrome 65

@alexreardon
Copy link
Collaborator

Sorry for the delay on this one. It got a bit lost. I am not able to reproduce your issue..

@alexreardon
Copy link
Collaborator

I misread, I didn't realise I needed to move everything. I can look into this asap

@alexreardon
Copy link
Collaborator

I am struggling to reproduce this locally

@alexreardon
Copy link
Collaborator

I know what your issue is. You have set isDropDisabled={destFull} so dropping on the home is not allowed when it is full. This causes the application to get confused when you move as it assumes you can only move over things that are not disabled. I should add some assistance to users who do this. I expect it is common to want to have drop disabled on a list but still be able to move things out of that list

@alexreardon alexreardon changed the title Cannot handle keyboard movement event if direction is not provided Cannot move with keyboard out of a isDropDisabled list May 17, 2018
@alexreardon
Copy link
Collaborator

I have a fix for this. I will create some tests tomorrow and get it merged

@nmain
Copy link
Author

nmain commented May 17, 2018

Thanks for looking into this! It will help out my application a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants