Update typings.d.ts #22
Conversation
typings.d.ts
Outdated
| errors: ErrorObject[], | ||
| options: betterAjvErrors.IInputOptions | ||
| errors: ErrorObject[] | null | undefined, | ||
| options: betterAjvErrors.IInputOptions | undefined |
There was a problem hiding this comment.
As per the JS signature.
There was a problem hiding this comment.
I would prefer
errors?: ErrorObject[],
options?: betterAjvErrors.IInputOptions
typings.d.ts
Outdated
| @@ -22,8 +22,8 @@ declare namespace betterAjvErrors { | |||
| ( | |||
| schema: any, | |||
| data: any, | |||
| errors: ErrorObject[], | |||
| options: betterAjvErrors.IInputOptions | |||
| errors: ErrorObject[] | null | undefined, | |||
There was a problem hiding this comment.
ajv.errors/validate.errorshave this type.- Your code has a fallback for falsy
errors, so this is safe.
|
Sorry for the delay for some reason I didn't get any email notifications from this repo. |
|
@torifat No worries. Replaced |
| @@ -22,8 +22,8 @@ declare namespace betterAjvErrors { | |||
| ( | |||
| schema: any, | |||
| data: any, | |||
| errors: ErrorObject[], | |||
| options: betterAjvErrors.IInputOptions | |||
| errors?: ErrorObject[] | null, | |||
There was a problem hiding this comment.
Yep! That's what made me make this PR, IIRC. Otherwise I have to assert that it isn't null first (or append a !), which is redundant.
There was a problem hiding this comment.
Cool, since this isn't a breaking change so I'm merging it but I will probably get rid of null from code in near future. Thanks for the PR 👍
There was a problem hiding this comment.
I don't follow, why allow undefined, but not null? In the link I provided, ajv's errors property on the validation function may be null.
|
Use |
|
Thanks 👍 |
chore(deps): update node.js to v14
A bit more relaxed now.