Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure global types for jest #180

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

jdanil
Copy link
Contributor

@jdanil jdanil commented Apr 29, 2020

Using configuration suggested by jest-extended.
https://github.com/jest-community/jest-extended#typescript

Fixes #176.

@itsdouges
Copy link
Collaborator

itsdouges commented Apr 29, 2020

thanks mate will have a look 😄

weird that the bundle size has increased. need to investigate. could it somehow be bringing cross-env i wonder.


as a side can you please have a read of https://github.com/atlassian-labs/compiled-css-in-js/blob/master/CONTRIBUTING.md and sign the CLA? https://na2.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=3f94fbdc-2fbe-46ac-b14c-5d152700ae5d

thanks so much 😃

@jdanil
Copy link
Contributor Author

jdanil commented Apr 29, 2020

I think it must be. I tried running it with just the cross-env change and bundlesize failed again with the same error.
I can't run bundlesize without the cross-env change so maybe I'll just try to back that part out (and just keep the jest changes) and see how it runs on CI.

@itsdouges
Copy link
Collaborator

itsdouges commented Apr 29, 2020

i think we can exclude them from the bundle size. let me check your stuff out locally and test.

its weird its even brought in at all, though

edit: ahh your removed it anyway. all good


if you want an extra contribution this would be a great addition to https://compiledcssinjs.com/docs/testing (adding what to do about types)

@itsdouges itsdouges merged commit 3a5fee2 into atlassian-labs:master Apr 29, 2020
@jdanil
Copy link
Contributor Author

jdanil commented Apr 29, 2020

Yeah it is. I couldn't find any mention of cross-env in the new bundles though so not really sure what was going on. Might look into it again if I get time to add to the testing docs.

@itsdouges
Copy link
Collaborator

@jdanil hey mate so your change works when running jest - but when using in the IDE we get this error

image

i think this is what happened last time i tried to fix this. any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out how to get jest matcher types working across the repo without needing to import them in every test
2 participants