Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bytes output #83

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Fix bytes output #83

merged 2 commits into from
Sep 28, 2020

Conversation

argilo
Copy link
Contributor

@argilo argilo commented Sep 27, 2020

This addresses the remaining pieces of #80:

  • extra whitespace is removed
  • bytes are decoded to strings before printing so they don't appear in repr() form

@argilo
Copy link
Contributor Author

argilo commented Sep 27, 2020

I tested this on Python 2 and 3 to verify that packet output is identical.

@atlas0fd00m
Copy link
Owner

doh! didn't see this before my last comment :)

@atlas0fd00m
Copy link
Owner

thanks @argilo !

@atlas0fd00m atlas0fd00m merged commit 7c5c208 into atlas0fd00m:master Sep 28, 2020
@argilo argilo deleted the fix-bytes-output branch September 30, 2020 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlas0fd00m atlas0fd00m atlas0fd00m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@argilo @atlas0fd00m