New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor scheme review #3446

Merged

aadcg merged 3 commits into master from minor-scheme-review

Aug 5, 2024

Member

aadcg commented Aug 5, 2024 •

edited

Loading

Checklist:

Git branch state is mergable.
Changelog is up to date (via a separate commit).
New dependencies are accounted for.
Documentation is up to date.
Compilation and tests ((asdf:test-system :nyxt/<renderer>))
- No new compilation warnings.
- Tests are sufficient.

aadcg added 3 commits

August 5, 2024 22:11


          urls: Minor review.

c4496f6


          urls(browser-schemes): Refactor.

b2cac65

The special-use-schemes aren't schemes, but special-use domain names.
Therefore they're out of place.


          renderer/gtk: Change behavior on invalid scheme.

293016c

aadcg merged commit c3b6bd7 into master

0 of 3 checks passed

aadcg deleted the minor-scheme-review branch

August 5, 2024 19:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet