Proposal for Limiting files under 10M, minor formatting change. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HTTP has its own HEAD method to receive the content size of future responses, e.g. curl -X HEAD 'http://m2.music.126.net/0h5rupavV0az1vzVuChHtQ==/1223756441722122.mp3' however may not be strictly followed. |
| @@ -55,6 +55,8 @@ | |||
| songname = d["data"]["songList"][0]["songName"] | |||
| artistName = d["data"]["songList"][0]["artistName"] | |||
| filename = "./" + songdir + "/"+songname+"-"+artistName+".flac" | |||
| if os.path.getsize(filename) < 10000 * 1024: #Source from http://stackoverflow.com/questions/8626325/most-efficient-way-to-delete-a-file-if-its-below-a-certain-size | |||
There was a problem hiding this comment.
The position of this code is not right.
We should check the file size and delete it after downloading.
Thank you for you pull request. :P
Sorry about the delay, I took a look again and think it should go after code.write(f.read())?
|
@wagerpascal Hi, your commit is conflict now. Could you please make a new patch according the new main.py? If you are busy, I can do that for you. |
|
@mysteriouss You are right. See this commit: 2f20433#diff-5bc02cefb3ea9e27f1a6776eabd1935dR65
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a possible solution that is also in the OS library at http://stackoverflow.com/questions/8626325/most-efficient-way-to-delete-a-file-if-its-below-a-certain-size that may be able to limit the file size to only above 10M.
Haven't been able to test it (see #1 ).