-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapstore refactoring #60
Conversation
Pulled up common methods from MapDB and BekerleyDB stores.
Now all contents are copied before being added to a persistent resource, reducing drastically the execution time and avoiding a tricky bug. Changed default time unit to Milliseconds.
Now, MapDB and BerkeleyDB have a common code for Stores.
@sunye nice work, I only have one concern on Store names: you simplified Store names in I would suggest to follow the existing convention and rename core-level stores @yvernageau what do you think? Renaming all the existing DirectWrite stores (not only in Map) could be interesting, especially because all low-level stores use a direct write approach, but I think this can be done later on master. |
Indeed, great work! I'm pretty agree with the naming problem, and I'm agree with its solution too. However, I'm agree by the simplification of the name of |
I didn't keep the prefix "DirectWrite" because as long as I understand, all stores directly write things. Moreover I propose to remove all the "DirectWrite" prefixes and only use it if we indeed have stores with a different behavior. |
@sunye There is a Read-only store in the HBase module. For now it extends Anyway for now we need to be consistent. I propose to keep the |
Now, MapDB and BerkeleyDB have a common code for Stores.