Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIN-974 : [master] allow upstream & downstream expand for cyclic assets #3335

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

rmovaliya
Copy link

Change description

Cyclic assets are part of upstream & downstream. Currently for cyclic assets that fall on leaf node, doesn't set any pagination flags. Changes in PR removes condition that prevents setting flags for visited edges.

Description here

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@rmovaliya rmovaliya marked this pull request as ready for review July 22, 2024 07:15
@rmovaliya rmovaliya merged commit 424203a into master Jul 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants