Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQ-306 Make data_source optional requirement #3328

Merged
merged 1 commit into from
Jul 10, 2024
Merged

DQ-306 Make data_source optional requirement #3328

merged 1 commit into from
Jul 10, 2024

Conversation

bichitra95
Copy link
Collaborator

@bichitra95 bichitra95 commented Jul 10, 2024 •
edited
Loading

Change description

Making data_source attribute optional in contract

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@bichitra95 bichitra95 merged commit b10a995 into master Jul 10, 2024
9 checks passed
@bichitra95 bichitra95 deleted the DQ-306 branch July 10, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@checkaayush checkaayush checkaayush approved these changes

Assignees
No one assigned
Labels
READY FOR REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bichitra95 @checkaayush