[stag] GOV-1295 Remove unwanted logging

addons/policies/bootstrap_heka_policies.json

@@ -0,0 +1,35 @@
+{
+  "entities":
+  [
+    {
+    "typeName": "AuthPolicy",
+    "attributes":
+    {
+      "name": "DENY_DATA_ACCESS_GUEST",
+      "qualifiedName": "DENY_DATA_ACCESS_GUEST",
+      "description": "deny data access for guest users",
+      "policyCategory": "bootstrap",
+      "policySubCategory": "default",
+      "policyServiceName": "heka",
+      "policyType": "deny",
+      "policyPriority": 1,
+      "policyUsers": [],
+      "policyGroups": [],
+      "policyRoles":
+      [
+        "$guest"
+      ],
+      "policyResourceCategory": "ENTITY",
+      "policyResources":
+      [
+        "entity:*",
+        "entity-type:*"
+      ],
+      "policyActions":
+      [
+        "select"
+      ]
+    }
+    }
+  ]
+}

atlas-hub/pre-conf/ranger/install/conf.templates/enable/atlas-atlas-audit.xml

@@ -111,12 +111,12 @@
 	<!-- Log4j audit provider configuration -->
 	<property>
 		<name>xasecure.audit.destination.log4j</name>
-		<value>true</value>
+		<value>false</value>
 	</property>	
 
 	<property>
 		<name>xasecure.audit.destination.log4j.logger</name>
-		<value>AUDIT</value>
+		<value>AUTH_AUDIT</value>
 	</property>	
 
 	<!-- ElasticSearch audit provider configuration -->

auth-agents-common/src/main/java/org/apache/atlas/plugin/policyengine/RangerPolicyEngineImpl.java

@@ -123,8 +123,6 @@ public RangerAccessResult evaluatePolicies(RangerAccessRequest request, String p
 			String requestHashCode = Integer.toHexString(System.identityHashCode(request)) + "_" + policyType;
 
 			perf = RangerPerfTracer.getPerfTracer(PERF_POLICYENGINE_REQUEST_LOG, "RangerPolicyEngine.evaluatePolicies(requestHashCode=" + requestHashCode + ")");
-
-			LOG.info("RangerPolicyEngineImpl.evaluatePolicies(" + requestHashCode + ", " + request + ")");
 		}
 
 		RangerAccessResult ret;

auth-agents-common/src/main/java/org/apache/atlas/plugin/util/RangerPerfTracer.java

@@ -34,7 +34,7 @@ public class RangerPerfTracer {
 	private final static String tagEndMarker = "(";
 
 	public static Log getPerfLogger(String name) {
-		return LogFactory.getLog("org.apache.atlas.perf." + name);
+		return LogFactory.getLog("org.apache.atlas.auth.perf." + name);
 	}
 
 	public static Log getPerfLogger(Class<?> cls) {

client-keycloak/src/main/java/org/apache/atlas/keycloak/client/AbstractKeycloakClient.java

@@ -81,7 +81,6 @@ public AbstractKeycloakClient(KeycloakConfig keycloakConfig) {
         okhttp3.Response response = chain.proceed(request);
         this.metricUtils.recordHttpTimer(timerSample, request.method(), rawPath, response.code(),
                 INTEGRATION, KEYCLOAK);
-        LOG.info("Keycloak: Request for url {} Status:{}", request.url(), response.code());
         return response;
     };
 
@@ -135,10 +134,11 @@ protected <T> retrofit2.Response<T> processResponse(retrofit2.Call<T> req) throw
                 return response;
             }
             String errMsg = response.errorBody().string();
-            LOG.error("Keycloak: Client request processing failed code {} message:{}", response.code(), errMsg);
+            LOG.error("Keycloak: Client request processing failed code {} message:{}, request: {} {}",
+                    response.code(), errMsg, req.request().method(), req.request().url());
             throw new AtlasBaseException(ERROR_CODE_MAP.getOrDefault(response.code(), BAD_REQUEST), errMsg);
         } catch (Exception e) {
-            LOG.error("Keycloak: request failed", e);
+            LOG.error("Keycloak: request failed, request: {} {}, Exception: {}", req.request().method(), req.request().url(), e);
             throw new AtlasBaseException(BAD_REQUEST, "Keycloak request failed");
         }
     }

repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java

@@ -991,7 +991,6 @@ public AtlasSearchResult directIndexSearch(SearchParams searchParams) throws Atl
             }
 
             String indexName = getIndexName(params);
-            LOG.info("directIndexSearch.indexName {}", indexName);
 
             indexQuery = graph.elasticsearchQuery(indexName);
 

repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java

@@ -284,26 +284,23 @@ private AtlasLineageOnDemandInfo getLineageInfoOnDemand(String guid, AtlasLineag
         LineageOnDemandConstraints lineageConstraintsByGuid = getAndValidateLineageConstraintsByGuid(guid, atlasLineageOnDemandContext);
         AtlasLineageOnDemandInfo.LineageDirection direction = lineageConstraintsByGuid.getDirection();
         int depth = lineageConstraintsByGuid.getDepth();
-
         AtlasLineageOnDemandInfo ret = initializeLineageOnDemandInfo(guid);
 
-        if (depth == 0) {
+        if (depth == 0)
             depth = -1;
-        }
-
-        if (!ret.getRelationsOnDemand().containsKey(guid)) {
+        if (!ret.getRelationsOnDemand().containsKey(guid))
             ret.getRelationsOnDemand().put(guid, new LineageInfoOnDemand(lineageConstraintsByGuid));
-        }
+
         AtomicInteger inputEntitiesTraversed = new AtomicInteger(0);
         AtomicInteger outputEntitiesTraversed = new AtomicInteger(0);
         if (isDataSet) {
             AtlasVertex datasetVertex = AtlasGraphUtilsV2.findByGuid(this.graph, guid);
-            if (direction == AtlasLineageOnDemandInfo.LineageDirection.INPUT || direction == AtlasLineageOnDemandInfo.LineageDirection.BOTH) {
+            if (direction == AtlasLineageOnDemandInfo.LineageDirection.INPUT || direction == AtlasLineageOnDemandInfo.LineageDirection.BOTH)
                 traverseEdgesOnDemand(datasetVertex, true, depth, new HashSet<>(), atlasLineageOnDemandContext, ret, guid, inputEntitiesTraversed);
-            }
-            if (direction == AtlasLineageOnDemandInfo.LineageDirection.OUTPUT || direction == AtlasLineageOnDemandInfo.LineageDirection.BOTH) {
+            if (direction == AtlasLineageOnDemandInfo.LineageDirection.OUTPUT || direction == AtlasLineageOnDemandInfo.LineageDirection.BOTH)
                 traverseEdgesOnDemand(datasetVertex, false, depth, new HashSet<>(), atlasLineageOnDemandContext, ret, guid, outputEntitiesTraversed);
-            }
+            AtlasEntityHeader baseEntityHeader = entityRetriever.toAtlasEntityHeader(datasetVertex, atlasLineageOnDemandContext.getAttributes());
+            ret.getGuidEntityMap().put(guid, baseEntityHeader);
         } else  {
             AtlasVertex processVertex = AtlasGraphUtilsV2.findByGuid(this.graph, guid);
             // make one hop to the next dataset vertices from process vertex and traverse with 'depth = depth - 1'
@@ -317,7 +314,6 @@ private AtlasLineageOnDemandInfo getLineageInfoOnDemand(String guid, AtlasLineag
             }
         }
         RequestContext.get().endMetricRecord(metricRecorder);
-
         return ret;
     }