Prevent setting text as HTML in Text
#2043
Merged
+47
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
text_dangerous_html
branch
3 times, most recently
from
32dddf5
to
7f97285
Compare
mvorisek
force-pushed
the
text_dangerous_html
branch
from
7f97285
to
df37eea
Compare
mvorisek
force-pushed
the
text_dangerous_html
branch
from
df37eea
to
f1c7e12
Compare
mvorisek
force-pushed
the
text_dangerous_html
branch
from
39291b8
to
57e32f1
Compare
mvorisek
force-pushed
the
text_dangerous_html
branch
from
50a4b2e
to
cf19e62
Compare
mvorisek
force-pushed
the
text_dangerous_html
branch
from
cf19e62
to
ec8e01b
Compare
DarkSide666
approved these changes
Nov 27, 2024
src/Text.php
Outdated
| $this->content .= $this->getApp()->getTag('p', [], $text); | ||
| $this->content[] = (new HtmlValue())->dangerouslySetHtml('<p>'); | ||
| $this->content[] = (new HtmlValue())->set($text); | ||
| $this->content[] = (new HtmlValue())->dangerouslySetHtml('</p>'); |
There was a problem hiding this comment.
here you could simply use $this->dangerouslyAddHtml('</p>');, but that's additional function call, so probably better not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2040