-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add master checkbox to Grid #1921
Add master checkbox to Grid #1921
Conversation
does not account the child checkbox states
I have a first working master checkbox but the code is ugly and it does not account for the indeterminate state if child checkboxes are changed. |
needs a Behat test master checkbox must reflect the child states - unchecked/"partially checked"/"all checked" if Fomantic-UI/jQuery cannot handle this in a few lines, the JS should be put into |
Ok, it works as of now with the indeterminate state if the child checkboxes are not all in the same state. I had some issues to have the javascript statements to appear at the proper position. I first wrote them in Still I feel the manner I use the javascript is not optimal because it does not look like other atk4/ui sources. |
…/github.com/mhuser/atk4-ui into add-master-checkbox-to-grid--addSelection()
I did not find any figures of the checkbox column inside the There seem to be no documentation updates to do because the core functionalities of |
3dfe1b5
to
1b28c35
Compare
@mhuser, thank for this great contribution and sorry for longer review! ❤ |
@mvorisek |
fix #1877
Add a master checkbox into grid header that enables to toggle selection of whole visible records.