Tuple-returning overload for EquiZip #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orace
commented
Oct 30, 2019
Orace
commented
- Create three new overload for EquiZip
- Duplicated the tests
atifaziz
reviewed
Oct 30, 2019
There was a problem hiding this comment.
Thanks for this PR and your help! I've done an initial review.
I wonder if duplicating the tests is worthwhile. If the simpler overloads delegate to the others taking a projection function as argument and we test the tuple-returning overloads then then the coverage should be the same, no?
Could you also update README with the new count of overloads?
atifaziz
requested changes
Oct 31, 2019
There was a problem hiding this comment.
Thanks! We're almost there! 🏁
Just one last thing:
Could you also update
READMEwith the new count of overloads?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.