-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching #27
Open
dmv1167
wants to merge
32
commits into
athuler:main
Choose a base branch
from
dmv1167:caching
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Caching #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented athuler#17
Implemented athuler#21
Added optional return types, removed None comparison with == and some redundant parentheses. Began testing on live timing. Added getStopById to Routes and Systems for use with live timing.
Vehicle getNextStop() and getEtas() use 3rd party API to get stops and times. Stop getNextVehicle() and getEtas() gets vehicles and times.
Run Tests on Pull Requests
…oes not wish to manually refresh systems.
You may need to merge |
That looked awfully messy but this PR should include I made the caches into dictionaries to allow for instant lookups when using any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have separated the caching mechanism I came up with into this branch. I understand if this isn't what you had in mind as the caches are stored with each object, and I'm willing to try to implement time based refreshing in some manner in the future.