Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dynamic partials #24

Merged
merged 4 commits into from
Oct 26, 2022
Merged

Support for dynamic partials #24

merged 4 commits into from
Oct 26, 2022

Conversation

athos
Copy link
Owner

@athos athos commented Oct 25, 2022

Mustache v1.3.0 introduced dynamic partials.

Dynamic partials are a variant of partials that determine which file to load depending on the data passed at rendering time.

This PR adds support for dynamic partials. It also updates the Mustache spec compliance test suite to the latest.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 90.92% // Head: 91.15% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (3a82904) compared to base (a652098).
Patch coverage: 98.11% of modified lines in pull request are covered.

❗ Current head 3a82904 differs from pull request most recent head 1490277. Consider uploading reports for the commit 1490277 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   90.92%   91.15%   +0.23%     
==========================================
  Files          12       12              
  Lines         959      984      +25     
  Branches       48       48              
==========================================
+ Hits          872      897      +25     
  Misses         39       39              
  Partials       48       48              
Impacted Files Coverage Δ
src/pogonos/render.cljc 88.46% <95.65%> (+1.22%) ⬆️
src/pogonos/nodes.cljc 93.75% <100.00%> (+0.41%) ⬆️
src/pogonos/parse.cljc 94.89% <100.00%> (+0.12%) ⬆️
src/pogonos/stringify.cljc 87.91% <100.00%> (+1.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@athos athos changed the title Support dynamic partials Support for dynamic partials Oct 25, 2022
@athos athos merged commit ef32ed9 into master Oct 26, 2022
@athos athos deleted the feature/dynamic-partials branch October 26, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant