Fix shadow-cljs warnings that complain about marker protocol #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although Pogonos now does not officially support shadow-cljs, while I was trying it privately, it told me there were some infer warnings, which
clj -Rcljs -m cljs.main
never ever complained:Roughly, these warnings seem to complain about a marker protocol (i.e.
Invisible
). After some exploration, it turned out that removing the protocol from the two record implementations resolved the warnings.This PR replaces the
Invisible
protocol with a new one namedIVisibility
, which has a single method. The change not only resolves the above issue, but also makes the caller code more straightforward. It is indeed a breaking change, but has almost no impact on user code, I guess.