Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wrapped to select fetch implementation based on node version #92

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

bobvandevijver
Copy link
Contributor

@bobvandevijver bobvandevijver commented Jan 26, 2024


@RobinBol
Copy link
Contributor

RobinBol commented Jan 26, 2024

There seems to an issue with the specific combination: Node.js v18 and the node-fetch npm module. When using this combination, Cloudflare security service detects an "online attack":

<h2 data-translate="blocked_why_headline">Why have I been blocked?</h2>
<p data-translate="blocked_why_detail">This website is using a security service to protect itself from online attacks. The action you just performed triggered the security solution. There are several actions that could trigger this block including submitting a certain word or phrase, a SQL command or malformed data.</p>
</div>

Using the native fetch (available as of Node.js v18), this issue is resolved.

@RobinBol RobinBol requested a review from hmeerlo January 26, 2024 12:56
@RobinBol RobinBol self-assigned this Jan 26, 2024
@RobinBol RobinBol merged commit c6792ea into athombv:master Jan 29, 2024
1 check failed
@bobvandevijver bobvandevijver deleted the fix-fetch branch January 29, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants