Fix: rounding large files #622
Merged
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@avdv Can you please take a look here |
avdv
reviewed
Sep 2, 2024
lib/colorls/core.rb
Outdated
| @@ -280,11 +280,21 @@ def chars_for_size | |||
| end | |||
|
|
|||
| def justify_size_info(size) | |||
| size_num = size[0][0..-4].rjust(chars_for_size, ' ') | |||
| size_num = displayable_size_num(size[0]).rjust(chars_for_size, ' ') | |||
There was a problem hiding this comment.
Instead of parsing the string after conversion, just use filesize.pretty(precision: 0) and filesize.to_s('B', precision: 0) respectively, in the tertiary expression in the line 263 in size_info. Then just change this to
size_num = size[0].rjust(chars_for_size, ' ')
ronn is dead, it depends on hpricot which is also dead.
avdv
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Thank you @ayushpoddar! I hope you don't mind me hijacking your PR to fix CI and refactor according to my comment above.
No issues @avdv. I am glad you took over since I wasn't available for making the requested changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description