build: use react 18 #2344
Merged
build: use react 18 #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
filipesilva
commented
Sep 5, 2022
| "react-codemirror2": "^7.2.1", | ||
| "react-colorful": "^5.4.0", | ||
| "react-day-picker": "^7.4.10", | ||
| "react-dom": "17.0.1", | ||
| "react-dom": "18.2.0", |
There was a problem hiding this comment.
re-frame-10x is using the old bootstrap and will error on startup, but I think it might be ok? See day8/re-frame-10x#367
There was a problem hiding this comment.
@filipesilva does this issue cause everything to fall back to 17? I assumed it would.
There was a problem hiding this comment.
I don't think so. Just that instantiation of react rendering, I think. You can have multiple react "instances" on the same page, controller different parts of the html, without interacting with each other.
chore: update chakra
shanberg
approved these changes
Sep 5, 2022
It will show a react 18 warning on dev, but it is harmless.
filipesilva
force-pushed
the
react-18
branch
from
158bbfb
to
e02abe2
Compare
We're not really using it anymore.
tangjeff0
added a commit
that referenced
this pull request
Sep 7, 2022
Revert "Merge pull request #2344 from filipesilva/react-18"
filipesilva
added a commit
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.