Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new comments end up in wrong thread #2307

Merged
merged 6 commits into from
Aug 25, 2022

Conversation

sid597
Copy link
Collaborator

@sid597 sid597 commented Aug 24, 2022

No description provided.

@sid597 sid597 requested a review from neotyk August 24, 2022 11:57
@vercel
Copy link

vercel bot commented Aug 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
athens ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 7:28AM (UTC)

Copy link
Collaborator

@neotyk neotyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/cljs/athens/views/pages/block_page.cljs Outdated Show resolved Hide resolved
Copy link
Collaborator

@tangjeff0 tangjeff0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I click on different notification messages, I see that the URL updates with a new block-uid, but the UI doesnt change.

@tangjeff0 tangjeff0 changed the title Fix comments not rendering fix: new comments end up in wrong thread Aug 25, 2022
@tangjeff0 tangjeff0 merged commit 83b2d89 into athensresearch:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants