Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve block performance #2266

Merged
merged 6 commits into from
Aug 9, 2022
Merged

Conversation

shanberg
Copy link
Collaborator

Outline renderer blocks watch to see when they're in the viewport.

When they are, they'll render their more expensive parts. When they aren't, they'll render leaner versions of themselves.

@vercel
Copy link

vercel bot commented Jul 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
athens ✅ Ready (Inspect) Visit Preview Aug 9, 2022 at 0:40AM (UTC)

Copy link
Collaborator

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -361,7 +361,7 @@

(when (= @drag-target :before) [drop-area-indicator/drop-area-indicator {:placement "above"}])

[editor/editor-component
[:f> editor/editor-component
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change do?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shanberg shanberg merged commit fffe9a2 into athensresearch:main Aug 9, 2022
@shanberg shanberg deleted the block-perf-by-view branch August 9, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants