Virtualize all pages #2157
Merged
Virtualize all pages #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shanberg
commented
Apr 22, 2022
shanberg
commented
- All Pages table is virtualized. Only the number of items that fit on the screen are rendered.
- All pages are still pulled from the db, which appears to be the speed limiter now, rather than rendering
- Layout slightly tweaked to support the new architecture
- Uses react-window instead of other libraries because of light weight and ease of use. Other virtualization libraries could be considered.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
filipesilva
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.