Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring: Navigation #2071

Merged
merged 20 commits into from
Mar 16, 2022
Merged

Conversation

neotyk
Copy link
Collaborator

@neotyk neotyk commented Mar 9, 2022

No description provided.

@vercel
Copy link

vercel bot commented Mar 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/athens-research/athens/5FikfGhrjXrvuvTDX2AN3hcuk9NV
✅ Preview: https://athens-git-fork-neotyk-feat-navigation-feat-mon-athens-research.vercel.app

Header, Linked & Unlinked sections.
Header, breadcrumbs & linked sections.
@neotyk neotyk changed the title Feature Monitoring: Navigation from Athena Feature Monitoring: Navigation Mar 16, 2022
@neotyk neotyk marked this pull request as ready for review March 16, 2022 13:02
Copy link
Collaborator

@tangjeff0 tangjeff0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it'd be helpful to have a helper function so we don't write

(if shift?
  :right-pane
  :main-pane)

eveyrwhere?

src/cljs/athens/listeners.cljs Outdated Show resolved Hide resolved
src/cljs/athens/listeners.cljs Outdated Show resolved Hide resolved
src/cljs/athens/views/blocks/core.cljs Outdated Show resolved Hide resolved
src/cljs/athens/views/blocks/textarea_keydown.cljs Outdated Show resolved Hide resolved
src/cljs/athens/views/blocks/textarea_keydown.cljs Outdated Show resolved Hide resolved
src/cljs/athens/views/blocks/textarea_keydown.cljs Outdated Show resolved Hide resolved
src/cljs/athens/views/blocks/textarea_keydown.cljs Outdated Show resolved Hide resolved
src/cljs/athens/views/left_sidebar.cljs Show resolved Hide resolved
src/cljs/athens/views/pages/node_page.cljs Outdated Show resolved Hide resolved
src/cljs/athens/views/pages/node_page.cljs Outdated Show resolved Hide resolved
src/cljs/athens/views/pages/node_page.cljs Outdated Show resolved Hide resolved
@neotyk
Copy link
Collaborator Author

neotyk commented Mar 16, 2022

Do you think it'd be helpful to have a helper function so we don't write

(if shift?
  :right-pane
  :main-pane)

eveyrwhere?

Yes, a bit verbose, but will do just fine for now.
Otherwise we'd have to pass along the event itself, which isn't always available.

@tangjeff0 tangjeff0 changed the title Feature Monitoring: Navigation Monitoring: Navigation Mar 16, 2022
@tangjeff0 tangjeff0 merged commit d66f294 into athensresearch:main Mar 16, 2022
@neotyk neotyk deleted the feat/navigation-feat-mon branch March 17, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants