Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image constraint #154

Merged
merged 6 commits into from
Mar 13, 2022
Merged

Image constraint #154

merged 6 commits into from
Mar 13, 2022

Conversation

Blacksmoke16
Copy link
Member

@Blacksmoke16 Blacksmoke16 commented Feb 26, 2022 •
edited
Loading

  • Make constraint validators classes
    • Internally required to allow for inheritance
    • Allows for them to share state when defined as services
  • Change order some File constraint args
  • Adds a new constraint to validate an image file meets various requirements, such as:
    • Width/height
    • ratio
    • pixels
    • shape
  • Adds dependency on https://github.com/athena-framework/image-size to handle determining image sizes

@Blacksmoke16 Blacksmoke16 force-pushed the image-constraint branch 2 times, most recently from a5627e6 to 9d4a30d Compare February 28, 2022 02:14
@Blacksmoke16 Blacksmoke16 merged commit efb71e9 into master Mar 13, 2022
@Blacksmoke16 Blacksmoke16 deleted the image-constraint branch March 13, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking component:validator kind:feature Brand new functionality
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Blacksmoke16